feat(elasticsearch): Extend search config with fields for script evaluation of every hit (#1143) #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to vendure-ecommerce#1136
Added the extractSessionToken function to the core package exports
…ge (vendure-ecommerce#1138) Added the extractSessionToken function to the core package exports
…uation of every hit (vendure-ecommerce#1143)
|
Hi, this looks really interesting! Before I dive in to a full review, could you please rebase these changes onto the latest |
|
Okay. I changed the target to the |
|
I would personally do it locally on the command line, using a rebase command. Let me know if you need any help with that (rebase can get a bit tricky sometimes). |
|
I've created a new PR (#1145) for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
customScriptFieldsto search result